Re: ToDo: show size of partitioned table

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ToDo: show size of partitioned table
Date: 2018-11-19 02:42:16
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sun, Nov 18, 2018 at 11:17:37PM -0300, Alvaro Herrera wrote:
> To be certain I'm not going against some old decision, I digged up
> Amit's old patches. Turns out he submitted psql's describe.c using the
> term "partitioned table" on August 10th [1] and then based on a
> discussion where Robert suggested calling these new objects "partition
> roots" instead to avoid confusion, it was changed to "table" in the next
> submission on August 26th [2]. It seems the right call to have used the
> term "table" in many places (rather than "partition roots"), but at
> least in psql's \dt it seems extremely useful to show the type as
> "partitioned table" instead, because it is one place where the
> distinction is clearly useful.


> In this thread there have been no contrary votes, so I'm pushing this
> part soon.
> [1]
> [2]

Sorry for degressing, but could you also update \di at the same time so
as it shows "partitioned index"? listTables() should be switched to use
partitioned tables and partitioned indexes, and permissionsList() has a
reference to partitioned tables. While on it, this gives the attached..

Attachment Content-Type Size
psql-partition.patch text/x-diff 968 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-11-19 02:43:19 Re: ATTACH/DETACH PARTITION CONCURRENTLY
Previous Message Alvaro Herrera 2018-11-19 02:38:24 Re: Psql patch to show access methods info