| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: move PartitionBoundInfo creation code |
| Date: | 2018-11-14 01:04:12 |
| Message-ID: | 20181114010412.GA13659@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 13, 2018 at 10:59:15AM -0300, Alvaro Herrera wrote:
> I gave the patch a read and it looks reasonable to me.
>
> Memory management in RelationBuildPartitionDesc is crummy, but I don't
> think it's this patch's fault.
I agree, and that shows up pretty clearly after the refactoring is done.
The mess is partially caused by the handling around the case where there
is no partition data to attach to PartitionDescData. I would personally
much prefer if we could also avoid using partition_bounds_copy.
It does not prevent the first refactoring step, so I have committed the
patch as it is already doing a lot.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-11-14 01:09:09 | Re: move PartitionBoundInfo creation code |
| Previous Message | Higuchi, Daisuke | 2018-11-14 00:53:48 | RE: [Bug Fix]ECPG: cancellation of significant digits on ECPG |