RE: [Bug Fix]ECPG: cancellation of significant digits on ECPG

From: "Higuchi, Daisuke" <higuchi(dot)daisuke(at)jp(dot)fujitsu(dot)com>
To: 'Tom Lane' <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: 'Dmitry Dolgov' <9erthalion6(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: [Bug Fix]ECPG: cancellation of significant digits on ECPG
Date: 2018-11-14 00:53:48
Message-ID: 1803D792815FC24D871C00D17AE95905D39101@g01jpexmbkw24
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
>I took a quick look at this.
Thank you for review.

>So I think that we ought to unconditionally make the sqlda value's digit
>buffer look just like the one we're copying, even when ndigits = 0,
>which just requires removing the tests on ndigits.

I agree with you. Seeing this thread[1], 'if (ndigits = 0)' was introduced only to avoid memcpy() crash. I do not know this solution was best or not, but no crash occurs in the current version. So, I also think 'if (ndigits = 0)' should be removed.

>In short, the attached.
Thank you for updating. This patch looks good to me.


Daisuke Higuchi

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-11-14 01:04:12 Re: move PartitionBoundInfo creation code
Previous Message Thomas Munro 2018-11-14 00:50:06 Re: Copy data to DSA area