Re: Make Windows print float exponents like everybody else?

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Make Windows print float exponents like everybody else?
Date: 2018-10-09 22:05:39
Message-ID: 20181009220539.ofeodw344niy5rsb@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2018-10-09 18:00:54 -0400, Tom Lane wrote:
> I can't believe I got no comments about this, so reposting it under
> a more attention-getting title ...
>
> In https://www.postgresql.org/message-id/29037.1539021687@sss.pgh.pa.us
> I wrote:
>
> > Also, we have quite a few variant expected-files that exist only to cater
> > for Windows' habit of printing three exponent digits where everybody else
> > prints just two. It struck me that it would not be hard, or expensive,
> > to undo that choice in snprintf.c (see attached untested patch). So we
> > could considerably reduce future maintenance pain for the affected tests
> > by getting rid of those files.
> >
> > As against that, Windows users might possibly complain that float output
> > looks different than they're used to. I'm not sure how much sympathy
> > I have for that position. If we reimplement float output for more speed,
> > as is under discussion in nearby threads, I doubt we'd trouble to preserve
> > this Windows-ism in the rewrite.
> >
> > Comments?

No pushback here. Lower likelihood of turning the buildfarm red, lower
likelihood of being embarrased. Good. ;)

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2018-10-09 22:21:12 Re: IDE setup and development features?
Previous Message Tom Lane 2018-10-09 22:00:54 Make Windows print float exponents like everybody else?