| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade failed with ERROR: null relpartbound for relation 18159 error. |
| Date: | 2018-10-07 01:15:32 |
| Message-ID: | 20181007011532.5mhrode2b6gdsgue@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Oct-05, Amit Langote wrote:
> On 2018/10/05 16:05, Michael Paquier wrote:
> >> As of commit 2fbdf1b38bc [1], which has been applied in 11 and HEAD
> >> branches, RelationBuildPartitionDesc emits an error if we don't find
> >> relpartbound set for a child found by scanning pg_inherits, instead of
> >> skipping such children. While that commit switched the order of creating
> >> pg_inherits entry and checking a new bound against existing bounds in
> >> DefineRelation in light of aforementioned change, it didn't in
> >> ATExecAttachPartition, hence this error.
> >>
> >> Attached patch fixes that.
> >
> > Could you please add a minimal regression test in your patch? That's
> > the second bug related to ATTACH PARTITION I am looking at today..
>
> OK, done, although I hope that's not bloating the tests.
Pushed to 11 and master. I'm not convinced that it's a good idea to
mess with 10 at this point -- the partitioning code is rather completely
different already ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2018-10-07 02:30:36 | Re: Relax transactional restrictions on ALTER ENUM ... ADD TYPE (redux) |
| Previous Message | Michael Paquier | 2018-10-07 00:45:37 | Re: Segfault when creating partition with a primary key and sql_drop trigger exists |