Re: when set track_commit_timestamp on, database system abort startup

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, 李海龙 <hailong(dot)li(at)qunar(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: when set track_commit_timestamp on, database system abort startup
Date: 2018-09-25 04:43:46
Message-ID: 20180925044346.GH1354@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Sawada-san,

On Mon, Sep 24, 2018 at 08:28:45AM +0900, Michael Paquier wrote:
> Wouldn't it be better to incorporate the new test as part of
> 004_restart.pl? This way, we avoid initializing a full instance, which
> is always a good thing as that's very costly. The top of this file also
> mentions that it tests clean restarts, but it bothers also about crash
> recovery.

I have been able to work on this bug, and rewrote the proposed test case
as attached. The test can only get on v11 and HEAD. What do you think?
--
Michael

Attachment Content-Type Size
fix_committs_recovery_v3.patch text/x-diff 3.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-09-25 04:49:47 PG vs macOS Mojave
Previous Message Andres Freund 2018-09-25 04:27:35 Re: Proposal for Signal Detection Refactoring