| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | tgl(at)sss(dot)pgh(dot)pa(dot)us, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | robertmhaas(at)gmail(dot)com, andres(at)2ndquadrant(dot)com, andrew(at)dunslane(dot)net, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Something fishy happening on frogmouth |
| Date: | 2018-09-24 06:32:41 |
| Message-ID: | 20180924063241.GA3873667@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 19, 2018 at 01:03:44PM +0900, Kyotaro HORIGUCHI wrote:
> Thank you for finding and fixing this.
>
> At Sat, 15 Sep 2018 18:21:52 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote in <15555(dot)1537050112(at)sss(dot)pgh(dot)pa(dot)us>
> > Noah Misch <noah(at)leadboat(dot)com> writes:
> > > Usually, the first srandom() call happens early in PostmasterMain(). I plan
> > > to add one to InitStandaloneProcess(), which substitutes for several tasks
> > > otherwise done in PostmasterMain(). That seems like a good thing even if DSM
> > > weren't in the picture. Also, initdb needs an srandom() somewhere;
> > > choose_dsm_implementation() itself seems fine. Attached.
> >
> > +1, but some comments would be good.
> +1, too.
Thanks for reviewing. I pushed with some comments.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chris Travers | 2018-09-24 08:15:18 | Re: Proposal for Signal Detection Refactoring |
| Previous Message | Andrey Borodin | 2018-09-24 05:12:05 | Re: amcheck verification for GiST |