| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fix help option of contrib/oid2name |
| Date: | 2018-08-20 08:38:08 |
| Message-ID: | 20180820083808.GA2339@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 20, 2018 at 03:51:07PM +0900, Tatsuro Yamada wrote:
> On 2018/08/20 13:54, Michael Paquier wrote:
> Therefore, "-P" is a manual bag. I investigated more using git log command and
> understood followings:
>
> 1. -P option was removed on 4192f2d85
> 2. -P option revived in only the manual on 2963d8228
Bruce did that to keep a trace of it in the docs, let's nuke it then, we
don't handle it and the documentation is mentioning the thing as
deprecated since 2010.
>> oid2name supports also PGDATABASE.
>
> As far as I know, this environment variable is also unused because
> I could not get the results as I expected. So, I didn't add it to the manual.
> For example, following command expected that it shows about "postgres", but
> it couldn't.
Yep, you're right.
> For now, I'm not sure about TAP test but I knew both utilities have no
> regression tests. It would be better to use something tests.
If you don't add them, I think that I would just that myself, just to
have some basics. Not that it is a barrier for this patch anyway.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-08-20 09:15:15 | Re: partitioning - changing a slot's descriptor is expensive |
| Previous Message | David Rowley | 2018-08-20 07:45:35 | Calculate total_table_pages after set_base_rel_sizes() |