| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alexandra Ryzhevich <aryzhevich(at)google(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Vladimir Rusinov <vrusinov(at)google(dot)com>, Dmitriy Potapov <atomsk(at)google(dot)com> |
| Subject: | Re: [PATCH] Add regress test for pg_read_all_stats role |
| Date: | 2018-08-02 19:38:11 |
| Message-ID: | 20180802193811.GC2247@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 02, 2018 at 06:25:14PM +0100, Alexandra Ryzhevich wrote:
> I have noticed that there is no regression tests for default monitoring
> roles such as pg_read_all_stats.
A bug has been recently fixed for that, see 0c8910a0, so having more
coverage would be welcome, now your patch has a couple of problems.
25fff40 is the original commit which has introduced pg_read_all_stats.
Your patch has a couple of problems by the way:
- database creation is costly, those should not be part of the main
regression test suite.
- Any roles created should use "regress_" as prefix.
- You should look also at negative tests which trigger "must be
superuser or a member of pg_read_all_settings", like say a "SHOW
stats_temp_directory" with a non-privileged user.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arthur Zakirov | 2018-08-02 19:38:34 | Re: [HACKERS] Bug in to_timestamp(). |
| Previous Message | Andres Freund | 2018-08-02 19:30:46 | Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. |