Re: [PATCH] Improve geometric types

On 07/27/2018 10:20 AM, Kyotaro HORIGUCHI wrote:
> Thank you for taking this.
>
> At Thu, 26 Jul 2018 17:12:50 +0200, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote in <672f4c42-6742-c1ec-e9a4-1994b815acc7(at)2ndquadrant(dot)com>
>> On 07/11/2018 07:13 PM, Emre Hasegeli wrote:
>>> New versions are attached after the <float.h> patch got in. I noticed
>>> tests failing on Windows [1] and added alternative .out file.
>>> [1]
>>> https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.5235
>>>
>>
>> The version posted about two weeks ago is slightly broken - AFAICS the
>> float.h includes in geo_ops.c and gistproc.c need to be part of 0002,
>> not 0003. Attached is a version fixing that.
>>
>> Barring objections, I'll get this committed over the next few days,
>> once I review all the individual parts once more. I'm planning to
>> commit the 6 parts separately, as submitted. No backpatching, as
>> discussed before.
>
> +1 for no backpatching, and not merging into single big patch.
>

I've committed the first two parts, after a review and testing.

As these two parts were primarily refactoring (and quite extensive),
this seems like a good place to wait if the buildfarm is happy with it.
If yes, I'll continue applying the patches that do fix/change the
behavior in various ways.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services