| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Lyes Ameddah <lyes(dot)amd(at)gmail(dot)com> |
| Subject: | Re: Add SKIP LOCKED to VACUUM and ANALYZE |
| Date: | 2018-07-24 02:40:49 |
| Message-ID: | 20180724024049.GE4035@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 23, 2018 at 02:27:48PM +0000, Bossart, Nathan wrote:
> Sorry for the delay on these patches! This is nearly identical to
> what I started writing last night, so it looks good to me.
Thanks for double-checking. I have pushed this one to move on with the
rest of the feature.
> +typedef enum ClusterOption
> +{
> + CLUOPT_RECHECK, /* recheck relation state */
> + CLUOPT_VERBOSE /* print progress info */
> +} ClusterOption;
>
> It looks like the last line here has a bit of extra whitespace
> compared to the other code in parsenodes.h.
That came from pgindent. I have just updated typedefs.list to take care
of it. There could be an argument about moving recheck out of
cluster_rel(), but that would not be nice with any module for example
calling this API, so its contract is unchanged.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kohei KaiGai | 2018-07-24 02:43:54 | Re: [report] memory leaks in COPY FROM on partitioned table |
| Previous Message | Craig Ringer | 2018-07-24 02:10:19 | Re: Have an encrypted pgpass file |