Re: Make foo=null a warning by default.

From: David Fetter <david(at)fetter(dot)org>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Make foo=null a warning by default.
Date: 2018-07-20 05:06:37
Message-ID: 20180720050637.GB29917@fetter.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Thu, Jul 19, 2018 at 06:37:39AM -0400, Fabien COELHO wrote:
>
> Hello David,
>
> All is nearly well, although "make docs" found a typo. I should have tested
> doc building before, sorry for this new round which should have been
> avoided.
>
> "<replacable>null_expression</replaceable>"
>
> s/<replacable>/<replaceable>/;

Fixed.

> Also, while reading the full documentation about the setting: I find this
> sentence a bit strange:
>
> """
> But new users are frequently confused about the semantics of expressions
> involving null values, so this option is off by default.
> """
>
> It appears to justify why the option is off by default, but this is not the
> actual reason, which was already provided at the end of the preceding
> paragraph.
>
> I would suggest to remove this "But..." sentence, or turn it differently,
> maybe something like:
>
> """ New users are frequently confused about the semantics of expressions
> involving null values: beware that turning this option on might bring even
> more confusion. """

I've changed it to something that makes more sense to me. Hope it
makes more sense to others.

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachment Content-Type Size
0001-Make-transform_null_equals-into-an-enum-v6.patch text/x-diff 12.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-07-20 05:22:17 Re: Possible performance regression in version 10.1 with pgbench read-write tests.
Previous Message Michael Paquier 2018-07-20 04:49:35 Re: de-deduplicate code in DML execution hooks in postgres_fdw