Re: Make foo=null a warning by default.

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: David Fetter <david(at)fetter(dot)org>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Make foo=null a warning by default.
Date: 2018-07-19 10:37:39
Message-ID: alpine.DEB.2.21.1807190611070.663@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello David,

All is nearly well, although "make docs" found a typo. I should have
tested doc building before, sorry for this new round which should have
been avoided.

"<replacable>null_expression</replaceable>"

s/<replacable>/<replaceable>/;

Also, while reading the full documentation about the setting: I find this
sentence a bit strange:

"""
But new users are frequently confused about the semantics of expressions
involving null values, so this option is off by default.
"""

It appears to justify why the option is off by default, but this is not
the actual reason, which was already provided at the end of the preceding
paragraph.

I would suggest to remove this "But..." sentence, or turn it differently,
maybe something like:

""" New users are frequently confused about the semantics of expressions
involving null values: beware that turning this option on might bring even
more confusion. """

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2018-07-19 10:50:15 Re: Runtime partition pruning for MergeAppend
Previous Message Kyotaro HORIGUCHI 2018-07-19 10:30:54 Re: [HACKERS] PATCH: Keep one postmaster monitoring pipe per process