Re: Make foo=null a warning by default.

From: David Fetter <david(at)fetter(dot)org>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Make foo=null a warning by default.
Date: 2018-07-19 05:52:18
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Jul 18, 2018 at 04:15:30PM -0400, Fabien COELHO wrote:
> >[...] Done.
> All looks well, but I just noticed a warning:
> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -O2 -I. -I. -I../../../../src/include -D_GNU_SOURCE -c -o guc.o guc.c
> guc.c:4090:3: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
> &transform_null_equals,
> ^
> guc.c:4090:3: note: (near initialization for ‘ConfigureNamesEnum[16].variable’)
> Too bad, gcc does not like an (enum*) there. Maybe cast to (int *), or
> declare the variable as an int (which seems to be what is done for others)?

Done that way.

David Fetter <david(at)fetter(dot)org>
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres:

Attachment Content-Type Size
0001-Make-transform_null_equals-into-an-enum-v5.patch text/x-diff 11.9 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-07-19 06:26:50 Re: print_path is missing GatherMerge and CustomScan support
Previous Message Michael Paquier 2018-07-19 05:35:42 Re: More consistency for some file-related error message