Re: Make foo=null a warning by default.

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: David Fetter <david(at)fetter(dot)org>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Make foo=null a warning by default.
Date: 2018-07-18 20:15:30
Message-ID: alpine.DEB.2.21.1807181604480.26741@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> [...] Done.

All looks well, but I just noticed a warning:

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -O2 -I. -I. -I../../../../src/include -D_GNU_SOURCE -c -o guc.o guc.c
guc.c:4090:3: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
&transform_null_equals,
^
guc.c:4090:3: note: (near initialization for ‘ConfigureNamesEnum[16].variable’)

Too bad, gcc does not like an (enum*) there. Maybe cast to (int *), or
declare the variable as an int (which seems to be what is done for
others)?

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-07-18 20:26:32 Re: psql's \d versus included-index-column feature
Previous Message David G. Johnston 2018-07-18 20:14:30 Re: psql's \d versus included-index-column feature