| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PG 10: could not generate random cancel key |
| Date: | 2018-07-18 13:01:09 |
| Message-ID: | 20180718130109.GH8565@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 18, 2018 at 10:14:56AM +0100, Dean Rasheed wrote:
> OK, I guess that it is possible that an older version of OpenSSL
> requires RAND_poll() to be called multiple times. Here's an updated
> patch doing that (with up to 8 retries, based on the old OpenSSL
> code).
Thanks for the updated version. This looks safer to me. It is possible
to simplify the code by removing the external RAND_status() call and
check for RAND_status() first in the loop as per the attached.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| pg_strong_random-v3-michael.patch | text/x-diff | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2018-07-18 13:01:34 | Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove pgbench "progress" test pending solution of its timing is (fwd) |
| Previous Message | Robert Haas | 2018-07-18 12:53:42 | Re: Libpq support to connect to standby server as priority |