| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Emre Hasegeli <emre(at)hasegeli(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: _isnan() on Windows |
| Date: | 2018-07-11 00:37:54 |
| Message-ID: | 20180711003754.GP1661@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 10, 2018 at 04:23:42PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> On 2018-Jul-10, Tom Lane wrote:
>>> I disagree --- including <float.h> in c.h, as this would have us do,
>>> seems like a huge expansion of the visibility of that header. Moreover,
>>> doing that only on Windows seems certain to lead to missing-header
>>> problems in the reverse direction, ie patches developed on Windows
>>> will fail elsewhere.
>
>> I don't think so, because that's only done for MSVC older than 2013.
>> Nobody uses that for new development anymore.
>
> Hm. OK, maybe it's all right given that. I'm still a bit worried
> about downsides, but no doubt the buildfarm will tell us.
It seems to me that this patch is a good idea. Any objections if I take
care of it? I have a Windows VM with only MSVC 2015 if I recall
correctly though...
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-07-11 00:41:46 | Re: no partition pruning when partitioning using array type |
| Previous Message | Tsunakawa, Takayuki | 2018-07-11 00:34:10 | RE: How can we submit code patches that implement our (pending) patents? |