| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org, petr(at)2ndquadrant(dot)com, simon(at)2ndQuadrant(dot)com |
| Subject: | Re: Non-reserved replication slots and slot advancing |
| Date: | 2018-07-10 07:59:07 |
| Message-ID: | 20180710075907.GK1661@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 10, 2018 at 12:26:30AM -0700, Andres Freund wrote:
> Why is the ReplicationSlotRelease() needed here? Souldn't the error
> handling code do so automatically?
Oh, indeed. I didn't know that PostgresMain was doing some cleanup
here. There is a second place where this can be removed, which comes
from the original commit which added the advance function. An updated
version is attached. Do you have other comments?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| slot-advance-unreserved-v5.patch | text/x-diff | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Iwata, Aya | 2018-07-10 08:03:44 | RE: hostorder and failover_timeout for libpq |
| Previous Message | 杨杰 | 2018-07-10 07:41:06 | user-friendliness improvement of pageinspect |