Re: pgsql: Add wait event for fsync of WAL segments

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add wait event for fsync of WAL segments
Date: 2018-07-09 21:41:12
Message-ID: 20180709214112.GA1661@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Jul 09, 2018 at 12:12:42PM -0700, Peter Geoghegan wrote:
> On Mon, Jul 9, 2018 at 11:24 AM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
> > Maybe we should add an XML comment
> > <!-- remember to update "morerows" above -->
> > at the end of the table :-)
>
> +1. I made the same mistake at one point.

Another idea that I have here, is to rework the page for monitoring
stats so as we create one sub-section for each system view, and also one
for the table of wait events. For the wait events, we could then
completely remove the first category column which has morerows and
divide the section into on table per event category.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-07-09 21:46:10 Re: no partition pruning when partitioning using array type
Previous Message Thomas Munro 2018-07-09 21:38:00 Re: [PATCH] Improve geometric types

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-07-09 23:26:45 pgsql: Avoid emitting a bogus WAL record when recycling an all-zero btr
Previous Message Tom Lane 2018-07-09 21:23:55 pgsql: Prevent accidental linking of system-supplied copies of libpq.so