| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add wait event for fsync of WAL segments |
| Date: | 2018-07-09 18:24:33 |
| Message-ID: | 20180709182433.wysgm7rizw2xkp4i@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2018-Jul-09, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
> > On Sun, Jul 08, 2018 at 10:23:37PM +0200, Julien Rouhaud wrote:
> >> I just noticed that the number of rows for the IO wait event type
> >> documentation hasn't been updated, see
> >> https://www.postgresql.org/docs/devel/static/monitoring-stats.html#WAIT-EVENT-TABLE.
> >> Trivial patch attached.
>
> > Thanks, Julien! Fixed. Indeed the table format was weird..
>
> Hm, do we need that "morerows" thing at all? It seems impossible
> that we'll remember to keep it up to date in future. How do you
> even check that it's right now?
Maybe we should add an XML comment
<!-- remember to update "morerows" above -->
at the end of the table :-)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-07-09 18:28:12 | pgsql: Fix yet more problems with incorrectly-constructed zero-length a |
| Previous Message | Bruce Momjian | 2018-07-09 15:19:31 | pgsql: rel notes: mention enabling of parallelism in PG 10 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-07-09 18:28:48 | Re: WAL prefetch |
| Previous Message | Andres Freund | 2018-07-09 18:24:09 | Re: How can we submit code patches that implement our (pending) patents? |