Re: Possible bug in logical replication.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Arseny Sher <a(dot)sher(at)postgrespro(dot)ru>
Cc: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, konstantin knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Possible bug in logical replication.
Date: 2018-07-09 07:02:00
Message-ID: 20180709070200.GC30202@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 03, 2018 at 09:16:42AM +0300, Arseny Sher wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> On Thu, Jun 21, 2018 at 07:31:20PM +0900, Michael Paquier wrote:
>>> Could it be possible to get a patch from all the feedback and exchange
>>> gathered here? Petr, I think that it would not hurt if you use the set
>>> of words and comments you think is most adapted as the primary author of
>>> the feature.
>>
>> I have seen no patch, so attached is one to finally close the loop and
>> this open item, which includes both my suggestions and what Arseny has
>> mentioned based on the latest emails exchanged. Any objections to that?
>
> I'm practically happy with this.
>
>> * while confirmed_lsn is used as base point for the decoding context.
>
> This line is excessive as now we have comment below saying it doesn't
> matter.

Okay, let's do as you suggest then. Do you find the attached adapted?
--
Michael

Attachment Content-Type Size
slot-advance-comment-v3.patch text/x-diff 2.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Taiki Kondo 2018-07-09 07:09:00 RE: Typo in Japanese translation of psql.
Previous Message Michael Paquier 2018-07-09 06:48:33 Re: Non-reserved replication slots and slot advancing