| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: XLogSegNoOffsetToRecPtr fixup |
| Date: | 2018-07-08 18:27:49 |
| Message-ID: | 20180708182749.ruetnwjmroui2svk@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-07-08 14:23:45 -0400, Alvaro Herrera wrote:
> Pursuant to closing comment in
> https://postgr.es/m/20180306214239.ospkf6ie7aa5gm4j@alvherre.pgsql
> here's a quick patch to change the order of arguments in
> XLogSegNoOffsetToRecPtr. Commit fc49e24fa69a ("Make WAL segment size
> configurable at initdb time.") put the walsegsz as last argument,
> *after* its output argument, which is downright weird.
>
> I propose to apply this to pg11 and master, to avoid an unnecessary API
> change in pg12.
WFM.
Thanks,
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2018-07-08 18:51:38 | Re: hot_standby_feedback vs excludeVacuum and snapshots |
| Previous Message | Alvaro Herrera | 2018-07-08 18:23:45 | XLogSegNoOffsetToRecPtr fixup |