| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | XLogSegNoOffsetToRecPtr fixup |
| Date: | 2018-07-08 18:23:45 |
| Message-ID: | 20180708182345.imdgovmkffgtihhk@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Pursuant to closing comment in
https://postgr.es/m/20180306214239.ospkf6ie7aa5gm4j@alvherre.pgsql
here's a quick patch to change the order of arguments in
XLogSegNoOffsetToRecPtr. Commit fc49e24fa69a ("Make WAL segment size
configurable at initdb time.") put the walsegsz as last argument,
*after* its output argument, which is downright weird.
I propose to apply this to pg11 and master, to avoid an unnecessary API
change in pg12.
--
Álvaro Herrera http://www.flickr.com/photos/alvherre/
| Attachment | Content-Type | Size |
|---|---|---|
| XLogSegNoOffsetToRecPtr.patch | text/plain | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-07-08 18:27:49 | Re: XLogSegNoOffsetToRecPtr fixup |
| Previous Message | Andres Freund | 2018-07-08 17:43:17 | Re: How can we submit code patches that implement our (pending) patents? |