| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Andres Freund <andres(at)anarazel(dot)de>, Onder Kalaci <onder(at)citusdata(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Optional message to user when terminating/cancelling backend |
| Date: | 2018-07-06 01:47:05 |
| Message-ID: | 20180706014705.GE2366@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 06, 2018 at 12:18:02PM +1200, Thomas Munro wrote:
> 6118 --select pg_cancel_backend(pg_backend_pid(), 'it brings on many changes');
> 6119 select pg_cancel_backend(pg_backend_pid(), NULL);
> 6120! ERROR: canceling statement due to user request
> 6121--- 25,32 ----
> 6122
> 6123 --select pg_cancel_backend(pg_backend_pid(), 'it brings on many changes');
> 6124 select pg_cancel_backend(pg_backend_pid(), NULL);
> 6125! pg_cancel_backend
> 6126! -------------------
> 6127! t
>
> Apparently Windows can take or leave it as it pleases.
>
> https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.4488
The test coverage looks adapted if it is possible to catch such
failures, so that's nice.
+select pg_cancel_backend();
+ERROR: function pg_cancel_backend() does not exist
+LINE 1: select pg_cancel_backend();
This negative test is not really necessary.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-07-06 01:49:50 | Re: documentation fixes for partition pruning, round three |
| Previous Message | Michael Paquier | 2018-07-06 01:45:07 | Re: Should contrib modules install .h files? |