Re: How to find the base version cf-bot is using?

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: thomas(dot)munro(at)enterprisedb(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: How to find the base version cf-bot is using?
Date: 2018-07-03 00:24:32
Message-ID: 20180703.092432.215556540.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hello. Thomas.

At Mon, 2 Jul 2018 22:14:42 +1200, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> wrote in <CAEepm=2w9=izjBEU+za78_shK6UpBnNGGAE0ysvQ5j9gnrhz8g(at)mail(dot)gmail(dot)com>
> On Mon, Jul 2, 2018 at 9:39 PM, Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> >> === applying patch ./v4-0001-Remove-entries-that-haven-t-been-used-for-a-certain-.patch
> > ...
> >> |Date: Tue, 26 Dec 2017 17:43:09 +0900
> > ...
> >> Patching file src/backend/utils/cache/plancache.c using Plan A...
> >> Hunk #1 failed at 63.
>
> That's complaining about patch 0004 in your patch set. The first 3
> apply OK, but it looks like maybe 0004 includes stuff that was already
> in 0001? cfbot tries to apply them all. I just tried it on HEAD
> myself:
...
> Here you show only patch 0001.

Mmm. The offsets grabed my attention. As your suggestion 0003
included the whole 0004. Thank you (and sorry) for the time to
check it.

Still I don't understand how git emitted the four broken
patchset, though.

> > How can I find the base version the CF-bot used at the time?
>
> Yeah. Sorry. I should include that information in the log to make it
> clearer what it's doing. I will do that in the next update.

Thank you.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-07-03 00:29:14 Re: Protect syscache from bloating with negative cache entries
Previous Message Andrew Dunstan 2018-07-02 23:14:58 Re: Protect syscache from bloating with negative cache entries