Re: Explain buffers wrong counter with parallel plans

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Adrien Nayrat <adrien(dot)nayrat(at)anayrat(dot)info>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Explain buffers wrong counter with parallel plans
Date: 2018-06-29 22:38:36
Message-ID: 20180629223836.4diuitc5mcowjqu2@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-Jun-29, Tom Lane wrote:

> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > I'm CCing Tom here, as author of the patch that caused (most of) the
> > issue.
>
> Uh ... me? I thought this was a parallel-query issue, which I've
> pretty much not been involved in.

Well, maybe it's a matter of opinion. Amit K said a few messages back
that your 01edb5c7fc3b ("Improve division of labor between
execParallel.c and nodeGather[Merge].c.") had changed the way these
numbers are printed, but only now I realize that he then indicated that
a different code path was already behaving in that way.

I stand by my opinion that we should not give misleading/confusing info;
either let's show it all in the default output, or only do it in
VERBOSE, but if the latter then let's suppress the misleading numbers in
the default output.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Srinivas Karthik V 2018-06-29 22:47:42 Re: Bulk Insert into PostgreSQL
Previous Message Alvaro Herrera 2018-06-29 22:29:06 Re: pgsql: Fix "base" snapshot handling in logical decoding