| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Pg Committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: Tips on committing |
| Date: | 2018-06-29 22:02:07 |
| Message-ID: | 20180629220207.GD31766@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Jun 28, 2018 at 09:46:17AM -0700, Peter Geoghegan wrote:
> * Don't assume that you haven't broken the doc build if you make even
> a trivial doc change. Removing a GUC can break instances in the
> release notes where they're referenced. Even grep can miss this, since
> references to the GUC will have dashes rather than underscores, plus
> possibly other variations.
Yes, I even check the docs after whitespace changes.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-06-29 22:29:06 | Re: pgsql: Fix "base" snapshot handling in logical decoding |
| Previous Message | Peter Eisentraut | 2018-06-29 19:27:53 | pgsql: Documentation spell checking and markup improvements |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-06-29 22:12:38 | Re: Explain buffers wrong counter with parallel plans |
| Previous Message | Alvaro Herrera | 2018-06-29 21:27:17 | Re: Internal error XX000 with enable_partition_pruning=on, pg 11 beta1 on Debian |