Re: Explain buffers wrong counter with parallel plans

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Adrien Nayrat <adrien(dot)nayrat(at)anayrat(dot)info>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Explain buffers wrong counter with parallel plans
Date: 2018-06-29 18:22:17
Message-ID: 20180629182217.ycqdq4dvu2ieryv5@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-Jun-08, Robert Haas wrote:

> On Wed, Jun 6, 2018 at 12:08 PM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
> > So, apparently this is not a Postgres 11 open item, but rather a bug
> > that goes back to pg10. However, maybe it would be worth fixing soon
> > anyway? In particular, if we want to perturb the explain output as
> > suggested upthread, maybe *that* should be considered an open item?
> >
> > Anyway, this has stalled for a month now.
>
> Yeah. I'm not willing to do anything here unilaterally. There is
> neither universal agreement that there is a problem here nor agreement
> on a fix. Unless that changes, I don't know what to do here.

After going over this whole thing once more, my opinion is that this
reporting is broken. IMO if we want to display per-process counts, then
let's display them all, or none; if we're going to display aggregated
counts, then we should mark them as such. Otherwise it's pretty much
impossible to read the output unless you know exactly what the code does
for each value. (The other option would be to document what the code
does for each value, but that seems suboptimal -- that just requires
people to glue one more cheat sheet to their walls, which is not Pg
style.)

I'm CCing Tom here, as author of the patch that caused (most of) the
issue.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2018-06-29 18:37:23 Re: ERROR: cannot start subtransactions during a parallel operation
Previous Message Tom Lane 2018-06-29 18:02:20 Re: Regression on PostgreSQL 10 ORDER/GROUP BY expression not found in targetlist