Re: Tips on committing

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Pg Committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: Tips on committing
Date: 2018-06-28 15:21:42
Message-ID: 20180628152142.GG6260@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Jun 28, 2018 at 11:14:38AM -0400, Alvaro Herrera wrote:
> I'm not sure pgsql-committers was the right audience. Cross-posting to
> pg-hackers.
>
> On 2018-Jun-28, Bruce Momjian wrote:
>
> > 2 Reported-by:
> > 5 Author:
> > 6 Reviewed-by:
> > 7 Tested-by:
>
> Should these include email addresses?

Uh, since I am linking to the thread it seemed unnecessary.

> I've also used "Diagnosed-by" to credit a person who spent time studying
> a bug's mechanism and how to fix it. Sometimes that's the same as
> Reported-by, but I think the weight is quite different.

Good point. I have never used it but I can see its value. I have added
it to my template.

> Apparently, there's a recent trend to credit patch authors using
> "Co-authored-by". Should we use that too?
> https://stackoverflow.com/a/41847267/

I would just list multiple authors.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2018-06-28 15:23:04 Re: Tips on committing
Previous Message Andres Freund 2018-06-28 15:20:13 Re: Tips on committing

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-06-28 15:23:04 Re: Tips on committing
Previous Message Andres Freund 2018-06-28 15:20:13 Re: Tips on committing