Re: Tips on committing

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Pg Committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: Tips on committing
Date: 2018-06-28 15:14:38
Message-ID: 20180628151438.o23cq6rpqcupqjwb@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

I'm not sure pgsql-committers was the right audience. Cross-posting to
pg-hackers.

On 2018-Jun-28, Bruce Momjian wrote:

> 2 Reported-by:
> 5 Author:
> 6 Reviewed-by:
> 7 Tested-by:

Should these include email addresses?

I've also used "Diagnosed-by" to credit a person who spent time studying
a bug's mechanism and how to fix it. Sometimes that's the same as
Reported-by, but I think the weight is quite different.

Apparently, there's a recent trend to credit patch authors using
"Co-authored-by". Should we use that too?
https://stackoverflow.com/a/41847267/

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-06-28 15:20:13 Re: Tips on committing
Previous Message Bruce Momjian 2018-06-28 13:26:13 Tips on committing

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-06-28 15:20:13 Re: Tips on committing
Previous Message Robert Haas 2018-06-28 14:26:13 Re: Forbid referencing columns by names in ALTER INDEX ... SET STATISTICS