Re: Small fixes about backup history file in doc and pg_standby

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Small fixes about backup history file in doc and pg_standby
Date: 2018-06-27 08:52:53
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, 26 Jun 2018 20:19:42 +0900 (Tokyo Standard Time)
Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:

> Hello.
> Good catch!
> At Tue, 26 Jun 2018 17:47:52 +0900, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote in <20180626174752(dot)0ce505e3(dot)nagata(at)sraoss(dot)co(dot)jp>
> > Hi,
> >
> > While looking into the backup and recovery code, I found small documentation bugs.
> > The documatation says that the backup history files can be requested for recovery,
> > but it's not used by the system and not requested anymore since PG 9.0
> > (commit 06f82b29616cd9effcaefd99c6b6e2e80697482f) and never be requested.
> >
> > Attached patch (doc_backup_history_file.patch) corrects the description about this.
> >
> > In addition, the current pg_standby still can handle a backup history file that are
> > never requested. It is harmless but unnecessary code. Another attached patch
> > (pg_standby.patch) removes this part of code.
> The comment fix seems fine and they seem to be all occurances of
> the word ".backup" in the context of recovery_command.
> The definition of the symbol XLOG_BACKUP_LABEL is no longer
> useful after your patch applied. Removing the symbol makes
> XLOG_DATA and the variable nextWALFileName useless and finally we
> can remove all branching using it.

Thank you for your reviewing my patch.

I've also removed XLOG_BACKUP_LABEL, but I left nextWALFileName
since this is still referred in CustomizableCleanupPriorWALFiles().

Attached is the updated patch.


> regards.
> --
> Kyotaro Horiguchi
> NTT Open Source Software Center

Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
pg_standby_v2.patch text/x-diff 832 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Sharma 2018-06-27 09:01:12 Utilisation of get_page_from_raw() in pageinspect
Previous Message Yugo Nagata 2018-06-27 08:42:07 Re: Small fixes about backup history file in doc and pg_standby