Re: Small fixes about backup history file in doc and pg_standby

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: nagata(at)sraoss(dot)co(dot)jp
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Small fixes about backup history file in doc and pg_standby
Date: 2018-06-26 11:19:42
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Good catch!

At Tue, 26 Jun 2018 17:47:52 +0900, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote in <20180626174752(dot)0ce505e3(dot)nagata(at)sraoss(dot)co(dot)jp>
> Hi,
> While looking into the backup and recovery code, I found small documentation bugs.
> The documatation says that the backup history files can be requested for recovery,
> but it's not used by the system and not requested anymore since PG 9.0
> (commit 06f82b29616cd9effcaefd99c6b6e2e80697482f) and never be requested.
> Attached patch (doc_backup_history_file.patch) corrects the description about this.
> In addition, the current pg_standby still can handle a backup history file that are
> never requested. It is harmless but unnecessary code. Another attached patch
> (pg_standby.patch) removes this part of code.

The comment fix seems fine and they seem to be all occurances of
the word ".backup" in the context of recovery_command.

The definition of the symbol XLOG_BACKUP_LABEL is no longer
useful after your patch applied. Removing the symbol makes
XLOG_DATA and the variable nextWALFileName useless and finally we
can remove all branching using it.


Kyotaro Horiguchi
NTT Open Source Software Center

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2018-06-26 11:45:49 Re: Online enabling of checksums
Previous Message Ashutosh Bapat 2018-06-26 11:03:52 Re: Thinko/typo in ExecSimpleRelationInsert