| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Nikhil Sontakke <nikhils(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Michael Paquier <michael(at)paquier(dot)xyz>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding |
| Date: | 2018-06-20 16:23:42 |
| Message-ID: | 20180620162342.zfpxeriuk4oafxln@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2018-Jun-15, Alvaro Herrera wrote:
> By the way, why do we need to strlen() the target buffer when strlcpy
> already reports the length? (You could argue that there is a difference
> if the string is truncated ... but surely we don't care about that case)
> I propose the attached.
I decided not to push this after all. Yes, one strlen is saved, but
there is some code clarity lost also, and this is certainly not a
contention point.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-06-20 16:58:42 | pgsql: Accept TEXT and CDATA nodes in XMLTABLE's column_expression. |
| Previous Message | Magnus Hagander | 2018-06-20 16:20:04 | pgsql: Add missing include |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-06-20 16:26:42 | Re: line numbers in error messages are off wrt debuggers |
| Previous Message | Tom Lane | 2018-06-20 16:12:26 | Re: line numbers in error messages are off wrt debuggers |