| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Nikhil Sontakke <nikhils(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Michael Paquier <michael(at)paquier(dot)xyz>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding |
| Date: | 2018-06-15 19:12:18 |
| Message-ID: | 20180615191218.py3ti2fzxlysxf7h@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
By the way, why do we need to strlen() the target buffer when strlcpy
already reports the length? (You could argue that there is a difference
if the string is truncated ... but surely we don't care about that case)
I propose the attached.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-no-need-for-separate-strlen.patch | text/plain | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2018-06-16 05:40:47 | pgsql: Fix memory leak in BufFileCreateShared(). |
| Previous Message | Alvaro Herrera | 2018-06-15 19:04:57 | Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2018-06-15 19:15:22 | Re: missing toast table for pg_policy |
| Previous Message | Alvaro Herrera | 2018-06-15 19:04:57 | Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding |