Re: pg_locale compilation error with Visual Studio 2017

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_locale compilation error with Visual Studio 2017
Date: 2018-05-12 12:36:16
Message-ID: 20180512123616.GA2026@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 11, 2018 at 10:39:07AM -0400, Tom Lane wrote:
> In the other thread, Munro wondered if ResolveLocaleName() would do
> the trick, but AFAICS nobody has tried it.

Indeed. I am pretty sure that it would be worth looking into that. The
VS docs shine by being obscure with this area, and each new version
arranges to make the locale lookups harder and harder.

> Another idea would be to replace the whole mess with a lookup table,
> although how to fill the table or maintain it in future would be
> problematic too.

Let's never do that..
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-05-12 15:30:11 Re: Should we add GUCs to allow partition pruning to be disabled?
Previous Message Christoph Berg 2018-05-12 06:46:12 Re: Compiler warnings with --enable-dtrace