| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [SPAM] Re: Local partitioned indexes and pageinspect |
| Date: | 2018-05-09 17:28:50 |
| Message-ID: | 20180509172850.2jsemd76ihygkde2@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier wrote:
> On Wed, May 02, 2018 at 01:38:22PM +0900, Amit Langote wrote:
> > Perhaps, I'm just repeating what's already been said, but I think it might
> > be better to have the word "partitioned" in the message.
>
> That's what Peter is pointing to upthread and what the v1 of upthread
> was doing. I would tend to think to just keep the code simple and don't
> add those extra checks, but I am fine to be beaten as well.
I pushed some fixes produced here. Attached is the remainder of the
patch you submitted. I notice now that we haven't actually fixed
Peter's source of complaint, though. AFAICS your patch just adds test
cases, and upthread discussion apparently converges on not doing
anything about the code. I'm not yet sure what to think of that ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-gaps-in-modules-with-handling-of-partitioned-.patch | text/plain | 12.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2018-05-09 17:37:48 | Re: [HACKERS] Clock with Adaptive Replacement |
| Previous Message | Robert Haas | 2018-05-09 16:00:25 | Re: [HACKERS] Clock with Adaptive Replacement |