Re: unused_oids script is broken with bsd sed

From: David Fetter <david(at)fetter(dot)org>
To: John Naylor <jcnaylor(at)gmail(dot)com>
Cc: Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unused_oids script is broken with bsd sed
Date: 2018-04-25 14:59:03
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Apr 25, 2018 at 09:55:54PM +0700, John Naylor wrote:
> On 4/25/18, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> wrote:
> >> On 25 Apr 2018, at 17:18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> I think we should rewrite
> >> both of them to use the infrastructure.
> >
> > Okay, seems reasonable. I'll put shared code in and
> > update patch.
> I don't think you need any new code in, I believe the
> suggestion was just to use that module as a stable interface to the
> data. Looking at your patch, I'll mention that we have an idiom for
> extracting #define'd OID symbols, e.g.:
> my $FirstBootstrapObjectId = Catalog::FindDefinedSymbol(
> 'access/transam.h', \(at)include_path, 'FirstBootstrapObjectId');

While we're improving things, there's not really a reason this program
should need to be run from any particular spot. It can detect where it
is and act on that information.

David Fetter <david(at)fetter(dot)org>
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres:

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Kuzmenkov 2018-04-25 15:01:36 Re: Reopen logfile on SIGHUP
Previous Message Sergei Kornilov 2018-04-25 14:57:43 Re: Reopen logfile on SIGHUP