Re: PATCH: Configurable file mode mask

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: David Steele <david(at)pgmasters(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Configurable file mode mask
Date: 2018-04-06 19:04:25
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


* Michael Paquier (michael(at)paquier(dot)xyz) wrote:
> On Fri, Apr 06, 2018 at 09:15:15AM -0400, Stephen Frost wrote:
> > I'll reply to David's last email (where the latest set of patches were
> > included) with my comments/suggestions and I expect we'll be able to get
> > those addressed today and have a final patch to post tonight, with an
> > eye towards committing it tomorrow.
> The feature freeze is on the 8th, so I am going to have limited room to
> comment on things until that day. If something gets committed, I am
> pretty sure that I'll get out of my pocket a couple of things to improve
> the feature and its interface anyway if of course you are ready to
> accept that. I have limited my role to be a reviewer, so I refrained
> myself from writing any code ;)

I'm, of course, happy to accept any further comments or suggestions on
it, pre-commit, post-commit, next year, whenever. ;)

I've posted an updated patch with comments and next steps, as discussed,
which I'm hopeful that David will have a chance to review and comment
on, at least, and perhaps help wrap up those last items. This patch has
been quite a slog, so thank you again for all of your help reviewing it
and moving it forward, it's been really appreciated.



In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marina Polyakova 2018-04-06 19:06:54 Re: Add support for printing/reading MergeAction nodes
Previous Message Stephen Frost 2018-04-06 19:02:10 Re: PATCH: Configurable file mode mask