| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: New files for MERGE |
| Date: | 2018-04-04 17:10:46 |
| Message-ID: | 20180404171046.udnure7thwkgo66h@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2018-04-03 08:32:45 -0700, Andres Freund wrote:
> Hi,
>
> On 2018-04-03 09:24:12 +0000, Simon Riggs wrote:
> > New files for MERGE
> > src/backend/executor/nodeMerge.c | 575 +++++++
> > src/backend/parser/parse_merge.c | 660 ++++++++
> > src/include/executor/nodeMerge.h | 22 +
> > src/include/parser/parse_merge.h | 19 +
>
> Getting a bit grumpy here. So you pushed this, without responding in
> any way to the objections I made in
> http://archives.postgresql.org/message-id/20180403021800.b5nsgiclzanobiup%40alap3.anarazel.de
> and did it in a manner that doesn't even compile?
This needs at the very least a response to the issues pointed out in the
referenced email that you chose to ignore without any sort of comment.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2018-04-04 17:16:50 | Re: pgsql: Optimize btree insertions for common case of increasing values |
| Previous Message | Alvaro Herrera | 2018-04-04 17:03:30 | pgsql: Foreign keys on partitioned tables |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-04-04 17:21:14 | Re: Foreign keys and partitioned tables |
| Previous Message | Tom Lane | 2018-04-04 17:08:31 | Re: Add support for printing/reading MergeAction nodes |