From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Commit 4dba331cb3 broke ATTACH PARTITION behaviour. |
Date: | 2018-04-02 16:00:23 |
Message-ID: | 20180402160023.ic5ti6tyei3zjqar@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> /*
> - * Check whether default partition has a row that would fit the partition
> - * being attached.
> + * Check if the default partition contains a row that would belong in the
> + * partition being attached.
> */
> - defaultPartOid =
> - get_default_oid_from_partdesc(RelationGetPartitionDesc(rel));
> if (OidIsValid(defaultPartOid))
Oh my. This code is terrible, and I think this patch is wrong. More
later.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Dmitry Ivanov | 2018-04-02 16:41:51 | Re: new function for tsquery creartion |
Previous Message | Peter Eisentraut | 2018-04-02 15:49:56 | Re: disable SSL compression? |