| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Change RangeVarGetRelidExtended() to take flags argument? |
| Date: | 2018-03-30 21:55:45 |
| Message-ID: | 20180330215545.3vvbxeqdyosaas65@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-03-30 17:08:26 +0000, Bossart, Nathan wrote:
> +typedef enum RelidOption
> +{
> + RELID_MISSING_OK = 1 << 0, /* don't error if relation doesn't exist */
> + RELID_NOWAIT = 1 << 1 /* error if relation cannot be locked */
> +} RelidOption;
I don't like the Relid prefix here. RangeVarGetRelid deals with
*rangevars*, and returns a relation oid. ISTM it'd be more accurate to
call this RV_* or RVID_*. Counterarguments, preferences?
Other than that this looks good, and I plan to push it later today.
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeremy Finzel | 2018-03-30 22:16:31 | Re: Passing current_database to BackgroundWorkerInitializeConnection |
| Previous Message | Andres Freund | 2018-03-30 21:40:37 | Re: Passing current_database to BackgroundWorkerInitializeConnection |