| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Partition-wise aggregation/grouping |
| Date: | 2018-03-26 22:03:23 |
| Message-ID: | 20180326220323.l2kelaomz3suf6a2@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-03-23 17:01:54 +0530, Jeevan Chalke wrote:
> Attached patch which fixes that.
Thanks, will push. For the future, I'd be more likely to notice if you
CC me ;)
> However, I am not sure whether it is expected to have stable regression run
> with installcheck having local settings.
> For example, If I have enabale_hashagg = false locally; I will definitely
> see failures.
>
> ISTM, that I am missing Andres point here.
I don't think there's a hard and fast rule here. I personally often
during development disable parallelism because it makes some things
harder (you can't easily debug crashes with gdb, benchmarks show larger
variance, ...). There doesn't seem to be an equivalent benefit to
support running e.g. with enabale_hashagg = false.
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-03-26 22:05:07 | Re: Parallel Aggregates for string_agg and array_agg |
| Previous Message | David Rowley | 2018-03-26 21:54:32 | Re: Parallel Aggregates for string_agg and array_agg |