Re: FDW Foreign Table Access: strange LOG message

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Albrecht Dreß <albrecht(dot)dress(at)arcor(dot)de>, Adrian Klaver <adrian(dot)klaver(at)aklaver(dot)com>, pgsql-general(at)lists(dot)postgresql(dot)org
Subject: Re: FDW Foreign Table Access: strange LOG message
Date: 2018-03-23 04:35:26
Message-ID: 20180323043334.GC1724@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

On Thu, Mar 22, 2018 at 06:55:12PM -0400, Tom Lane wrote:
> Anyway, it's clearly not very nice that postgres_fdw makes no attempt
> to do a graceful shutdown of its remote connection. I don't know that
> this rises to the level of a bug, exactly, but if somebody wanted to
> send in a patch it'd probably get accepted.

I won't qualify that as a bug, this is mainly noise. Still I agree that
it would be cleaner to make more efforts in finishing the connections
when the session goes down. You would roughly just need to register an
on_shmem_exit callback which loops through all the connections to finish
them. Now would we want to slow down the session shutdown just for
that? I am less sure particularly if there is lag between the remote
and the local servers.
--
Michael

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2018-03-23 04:59:24 Re: FDW Foreign Table Access: strange LOG message
Previous Message Peter Geoghegan 2018-03-23 00:11:42 Re: found xmin from before relfrozenxid on pg_catalog.pg_authid