| From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | alvherre(at)2ndquadrant(dot)com |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Some message fixes |
| Date: | 2018-03-08 02:26:20 |
| Message-ID: | 20180308.112620.43079984.horiguchi.kyotaro@lab.ntt.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Wed, 7 Mar 2018 07:10:34 -0300, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote in <20180307101034(dot)l7z7kqwqfkjg6c2p(at)alvherre(dot)pgsql>
> Kyotaro HORIGUCHI wrote:
>
> > 1. some messages are missing partitioned table/index
..
> I *think* the idea here is that a partitioned table is a table, so there
> is no need to say "foo is not a table or partitioned table". We only
> mention partitioned tables when we want to make a distinction between
> those that are partitioned and those that aren't.
I agree with the direction and code seems following that. I
should have looked wider.
Thanks.
> > 2. GUC comment for autovacuum_work_mem has a typo, "max num of
> > parallel workers *than* can be..". (Third attached)
>
> Yeah, pushed, though it's parallel_max_workers not autovacuum_work_mem.
Ugg. Inconsistency within a line.. My fingers may have decided to
do somewhat different from my brain.
Anyway, thank you for commiting.
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Gould | 2018-03-08 02:27:30 | Re: [patch] BUG #15005: ANALYZE can make pg_class.reltuples inaccurate. |
| Previous Message | Andres Freund | 2018-03-08 02:18:28 | Re: RFC: Add 'taint' field to pg_control. |