| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Sergei Kornilov <sk(at)zsrv(dot)org> |
| Cc: | Ildar Musin <i(dot)musin(at)postgrespro(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: using index or check in ALTER TABLE SET NOT NULL |
| Date: | 2018-03-06 17:25:28 |
| Message-ID: | 20180306172528.xnelm3xcq2qeyd2g@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Sergei Kornilov wrote:
> Hello, Ildar
> Thanks. I looked ATTACH PARTITION tests and found such checks. If no one is against i will just use in my patch INFO level instead DEBUG1, similarly ATTACH PARTITION code. Updated patch attached.
>
> Or i can rewrite tests to use DEBUG1 level.
You should be able to use an event trigger that raises a message when
table_rewrite is hit, to notify the test driver that a rewrite happens.
(If any DDL that causes a table rewrite fails to trigger the
table_rewrite event correctly, that is a bug.)
ISTM that depending on DEBUG messages is bad because debugging lines
added elsewhere will make your tests fail; and INFO is generally frowned
upon (I, for one, would frown upon an INFO message raised by ALTER
TABLE, for sure.) so let's not do that either.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-03-06 17:36:43 | Re: [patch] BUG #15005: ANALYZE can make pg_class.reltuples inaccurate. |
| Previous Message | Dmitry Dolgov | 2018-03-06 17:21:51 | Re: [HACKERS] [PATCH] Generic type subscripting |