Re: Rewrite of pg_dump TAP tests

Stephen Frost wrote:
> Greetings,
>
> * Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> > Attached is a patch (which applies cleaning against a2a2205, but not so
> > much anymore, obviously, but I will fix after the releases) which
> > greatly improves the big pg_dump TAP tests. There's probably more which
> > can be done, but I expect people will be much happier with this. The
> > cliff-notes are:
>
> Attached is an updated patch which applies cleanly against current
> master. I've not yet looked into back-patching these changes, but will
> if this can get some review and feedback, and folks like this better and
> are ok with the same being done in the back-branches.

Just looking at the commit message (sql script not dumped to screen),
and the fact that this removes the bulk of the like/unlike arrays, I'd
say this is a definite improvement over the existing tests.

Perhaps we'd like to tweak more later, but this is a good step forward
IMO.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services