Re: Rewrite of pg_dump TAP tests

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Rewrite of pg_dump TAP tests
Date: 2018-03-06 17:07:16
Message-ID: 20180306170716.qz3cfwoc262uplnn@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Stephen Frost wrote:
> Greetings,
> * Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> > Attached is a patch (which applies cleaning against a2a2205, but not so
> > much anymore, obviously, but I will fix after the releases) which
> > greatly improves the big pg_dump TAP tests. There's probably more which
> > can be done, but I expect people will be much happier with this. The
> > cliff-notes are:
> Attached is an updated patch which applies cleanly against current
> master. I've not yet looked into back-patching these changes, but will
> if this can get some review and feedback, and folks like this better and
> are ok with the same being done in the back-branches.

Just looking at the commit message (sql script not dumped to screen),
and the fact that this removes the bulk of the like/unlike arrays, I'd
say this is a definite improvement over the existing tests.

Perhaps we'd like to tweak more later, but this is a good step forward

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2018-03-06 17:21:51 Re: [HACKERS] [PATCH] Generic type subscripting
Previous Message David Steele 2018-03-06 16:59:30 Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug