From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | David Steele <david(at)pgmasters(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: 2018-03 Commitfest starts tomorrow |
Date: | 2018-03-02 08:00:35 |
Message-ID: | 20180302080035.j5tmieyk5v5unf53@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2018-03-01 00:42:25 -0500, Tom Lane wrote:
> As of right now, there are 229 entries in this commitfest (not counting
> the items already committed or RWF).
>
> It's hard for me to tell for sure, because the activity log page doesn't
> stretch back far enough, but I think about 40 of those have been created
> in the last 24 hours. It's certainly well over 20, because the log does
> go back far enough to show 21 patch records created since about noon
> Wednesday UTC.
>
> This is NOT how it is supposed to work. This is gaming the system.
Strongly agreed. There's a lot of stuff in here that has really no place
being there.
> I think that we should summarily bounce to the September 'fest anything
> submitted in the last two days; certainly anything that's nontrivial.
I've now gone through all the patches and commented on each of them in a
summary http://archives.postgresql.org/message-id/20180302075242.yfqkcgzbrmjysboa%40alap3.anarazel.de
I've sent comments to many of the ones that were submitted very
late.
I personally don't see much of a difference between submitting a brand
new patch 2018-02-15 and 2018-02-25. There's rarely a meaningful
difference in the amount of review features have gotten.
> There is no way that we can possibly handle 200+ CF entries in a month.
> A large fraction of these are going to end up pushed to September no
> matter what, and I think simple fairness demands that we spend our
> time on the ones that are not Johnny-come-latelies.
A surprisingly large part of those are ones that haven't meaningfully
evolved between the last few CFs. I think we need to used 'moved to
next CF' a lot less frequently.
> We also need to be pretty hard-nosed about quickly bouncing anything
> that's not realistically going to be able to get committed this month.
> I've not gone through the list in detail, but there are at least several
> waiting-on-author items that have seen no activity since the last 'fest.
> I'd recommend marking those RWF pretty soon.
I've done so, or proposed doing so, for a lot of them.
Having gone through all patches and having at least opened each of the
~230 open items, one thing that makes me extremely unhappy is that
there's a *massive* imbalance around reviews. There's a few folks that
do a lot of reviews in a lot of different areas, and there's others that
have lot and lots of huge patches open but don't do much to help others.
I don't think that's ok.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2018-03-02 08:00:52 | Re: Changing the autovacuum launcher scheduling; oldest table first algorithm |
Previous Message | Masahiko Sawada | 2018-03-02 07:53:42 | Re: [HACKERS] GUC for cleanup indexes threshold. |