On Thu, Dec 28, 2017 at 01:45:54PM -0500, Peter Eisentraut wrote: > An earlier patch I posted defines GinTernaryValue to be the same size as > bool, accounting for different possible sizes of bool.
Doh. I forgot this one. Yes that approach is fine.
> Here is a new patch set that picks up the best pieces of the recent > discussions: We use stdbool.h if available, use bool8 in the system > catalogs, define GinTernaryValue to be the same size as bool, and > rewrite the GinNullCategory code to work without casting.
I have looked at 0002 and 0003. Those look good to ship for me. -- Michael