Re: Add PGDLLIMPORT lines to some variables

From: Noah Misch <noah(at)leadboat(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Brian Cloutier <brian(at)citusdata(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add PGDLLIMPORT lines to some variables
Date: 2017-12-05 01:41:25
Message-ID: 20171205014125.GA3265301@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 20, 2017 at 12:02:30PM -0800, Andres Freund wrote:
> On 2017-11-20 11:58:44 -0800, Brian Cloutier wrote:
> > > please, append session_timezone to your list
> >
> > Here's a v2 patch which also includes session_timezone.
> >
> > Separately, is this the kind of thing which is eligible for backporting
> > into the next releases of 9.6 and 10?
>
> I don't think we quite have an established protocol for this. I
> personally, but I'm biased in this specific case, is that we should
> adopt a position that PGDLLIMPORTs should basically backpatched whenever
> a credible extension even halfway reasonably requires it. There's no
> easy way to get this done by default, and we're so far unwilling to just
> slap this onto every variable. So to not further disadvantage people
> force dto live in the MS environment, that seems the sanest
> solution. It's not like these are high risk.

+1

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-12-05 01:45:27 Re: Error handling (or lack of it) in RemovePgTempFilesInDir
Previous Message Michael Paquier 2017-12-05 01:34:00 Re: Errands around AllocateDir()