|From:||Anthony Bykov <a(dot)bykov(at)postgrespro(dot)ru>|
|Subject:||Re: Transform for pl/perl|
|Views:||Raw Message | Whole Thread | Download mbox|
On Wed, 15 Nov 2017 08:58:54 +0000
Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> wrote:
> The following review has been posted through the commitfest
> application: make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
> Hello Anthony,
> Great patch! Everything is OK and I almost agree with Pavel.
> The only thing that I would like to suggest is to add a little more
> tests for various corner cases. For instance:
> 1. Converting in both directions (Perl <-> JSONB) +/- infinity, NaN,
> MAX_INT, MIN_INT.
> 2. Converting in both directions strings that contain non-ASCII
> (Russian / Japanese / etc) characters and special characters like \n,
> \t, \.
> 3. Make sure that converting Perl objects that are not representable
> in JSONB (blessed hashes, file descriptors, regular expressions, ...)
> doesn't crash everything and shows a reasonable error message.
> The new status of this patch is: Waiting on Author
Thank you for your review.
I've added more tests and I had to change behavior of transform when
working with not-representable-in-JSONB format objects - now it will
through an exception. You can find an example in tests.
Please, find the 4-th version of patch in attachments.
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
|Next Message||Thomas Munro||2017-11-27 10:47:05||Re: ERROR: too many dynamic shared memory segments|
|Previous Message||Jakub Glapa||2017-11-27 09:54:03||ERROR: too many dynamic shared memory segments|